[1/2][backend] Eng 2196 m2 allow user to configure notifications #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
…ng-2196-m2-allow-user-to-configure-notifications-be
…ng-2196-m2-allow-user-to-configure-notifications-be
…ng-2196-m2-allow-user-to-configure-notifications-be
likawind
changed the title
saurav-c
approved these changes
Feb 2, 2023
likawind
added a commit
that referenced
this pull request
Feb 6, 2023
* [2/2][UI] Eng 2193 Allow connecting to email as integration (#897) * [1/2][Backend] Eng 2191 add slack integration to backend (#911) * [2/2][UI] Eng 2191 Allow user to connect to slack integration (#910) * Eng 2194 m2 implement go interface for (#923) * [1/2][backend] Eng 2196 m2 allow user to configure notifications (#935) * [2/2][UI] Eng 2196 m2 allow user to configure wf specific notifications (#936) * Implement actual code to send email notifications (#943) * Implement actual code to send slack notifications (#944)
likawind
deleted the
eng-2196-m2-allow-user-to-configure-notifications-be
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and why you are making these changes
This PR adds backend supports to allow API routes to create and edit workflow with
NotificationSettingsfield. The simple part is to add this field to a few route handlers and propengate the change through.The hard part is changing the current top-level
NotificationSettingsfield type from map to struct. This is causing problem when callingUpdatewith a map object, where the SQL driver complains aboutmaptype not supported, which leads to this: snowflakedb/gosnowflake#217 .Related issue number (if any)
ENG-2196
Loom demo (if any)
https://www.loom.com/share/b7929818b83743d881db8d712675fdc3
Checklist before requesting a review
python3 scripts/run_linters.py -hfor usage).run_integration_test: Runs integration testsskip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)