-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2/2][UI] Eng 2196 m2 allow user to configure wf specific notifications #936
[2/2][UI] Eng 2196 m2 allow user to configure wf specific notifications #936
Conversation
…nto eng-2196-m2-allow-user-to-configure-notifications-ui
…nto eng-2196-m2-allow-user-to-configure-notifications-ui
…nto eng-2196-m2-allow-user-to-configure-notifications-ui
@@ -226,6 +232,28 @@ type WorkflowSettingsProps = { | |||
onClose: () => void; | |||
}; | |||
|
|||
// Returns whether `updated` is different from `existing`. | |||
function IsNotificationSettingsMapUpdated( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish Typescript had a built in function to do this, but I'm not aware that it does :)
Nice work! @likawind Code looks good here, would like to see demo to give any design feedback. |
…nto eng-2196-m2-allow-user-to-configure-notifications-ui
…nto eng-2196-m2-allow-user-to-configure-notifications-ui
@agiron123 demo is updated! |
Just watched the demo. This is great! Nice work! |
A couple questions/notes just from watching the demo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting my comments above ^
All great comments, thanks @kenxu95 ! I'm going to fix 1 in this PR and learn more feedbacks on 3 in today's demo. For 2 and 4 both requires a bit more work (esp. 2 which requires some backend work), so we will have tasks to address them separately, just to keep the PR in relative small size |
@vsreekanti , I know there are a few places we would like to improve. But I do want to merge the stack given we are not opening the feature to users, and I'd like to have all tasks in this stack marked as done. So I will merge this PR together with others, but feel free to keep leaving notes. We can address them separately before we release to users! |
* Implement actual code to send slack notifications (#944)
ec03048
into
eng-2196-m2-allow-user-to-configure-notifications-be
* [2/2][UI] Eng 2193 Allow connecting to email as integration (#897) * [1/2][Backend] Eng 2191 add slack integration to backend (#911) * [2/2][UI] Eng 2191 Allow user to connect to slack integration (#910) * Eng 2194 m2 implement go interface for (#923) * [1/2][backend] Eng 2196 m2 allow user to configure notifications (#935) * [2/2][UI] Eng 2196 m2 allow user to configure wf specific notifications (#936) * Implement actual code to send email notifications (#943) * Implement actual code to send slack notifications (#944)
Describe your changes and why you are making these changes
This PR adds necessary UI changes to configure workflow-specific notification settings, based on backend changes introduced in #935 . We added a new settings section which allow users to add notification settings:
Related issue number (if any)
ENG-2196
Tests
We tested the following scenarios. We verified all changes are persisted and workflows are successfully run:
Loom Demo https://www.loom.com/share/b7929818b83743d881db8d712675fdc3
Checklist before requesting a review
python3 scripts/run_linters.py -h
for usage).run_integration_test
: Runs integration testsskip_integration_test
: Skips integration tests (Should be used when changes are ONLY documentation/UI)