fix(payment-detection): differenciate decentralized network case #1267
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fixup for #1262 and #1265
Context
When using TheGraph decentralized network, different GQL queries can target different indexers. For consistency, we can ask to target only indexers that have processed specific blocks using a block filter.
For more info, see here or here, look for
number_gte
in these pages.Description of the change
When we don't have the data for which minimum block an indexer should have processed, we must set a default value. After several unsuccessful tries, here is what I've found regarding generating a default value that works with both a normal TheGraph Node and the decentralized gateway:
undefined
Invalid query: Failed to determine block constraints.
null
Invalid query: Failed to determine block constraints.
{}
Invalid value provided for argument block: Object({})
{ number_gte: 0 }
Invalid query: Requested block before minimum startBlock of manifest: 0
This shows that no default value is compatible with both setups. We need to differentiate between both. I've added a new
decentralizedNetwork
boolean option that auto-populates depending on the URL value and allows to distinguish between both cases.