Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payment-detection): default block filter on decentralized network #1363

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

alexandre-abrioux
Copy link
Member

@alexandre-abrioux alexandre-abrioux commented Mar 15, 2024

Description of the changes

This is a follow-up on #1267, the decentralized gateway of TheGraph has changed its validation regarding accepted values on block filters. We need to change the default when no block filter is used.

Block Filter TheGraph Node TheGraph Gateway (decentralized)
undefined Invalid query: Failed to determine block constraints.
null Invalid query: Failed to determine block constraints.
empty object: {} Invalid value provided for argument block: Object({}) Invalid value provided for argument block: Object({})
default to zero: { number_gte: 0 }

@benjlevesque benjlevesque merged commit 6d3553f into master Mar 18, 2024
26 checks passed
@benjlevesque benjlevesque deleted the fix-decentralized-network-detection branch March 18, 2024 10:51
@MantisClone
Copy link
Member

Interesting 🤔 Nice work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants