Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rdspec and protectedpvcs condition #1605

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Commits on Oct 24, 2024

  1. Fix VRG resource updates causing RDSpec list alternation

    Fix an issue where the VRG resource was frequently updated, causing the RDSpec
    to alternate between an empty and non-empty list. This behavior directly impacted
    failover and relocation. If the list was empty during these actions, PVC restore
    was skipped, leading to incomplete recovery.
    
    Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
    Benamar Mekhissi committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    a4b9655 View commit details
    Browse the repository at this point in the history
  2. Update function to return last operation result and error

    This commit modifies the utility function that creates the ManifestWork to return
    an additional value indicating the last operation result alongside the error. The
    result can be one of three values: created, updated, or none. This change is
    needed to track whether the ManifestWork resource was newly created, updated, or
    left unchanged.
    
    Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
    Benamar Mekhissi committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ff0facb View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Unit test to validate RDSpec changes

    Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
    Benamar Mekhissi committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    757c3cf View commit details
    Browse the repository at this point in the history
  2. Fix rare issue with missing PVsRestored condition in ProtectedPVC.

    In certain edge cases, ProtectedPVCs may fail to add the PVsRestored condition
    permanently, causing the relocate process to get stuck in the WaitForReadiness
    progression.
    
    Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
    Benamar Mekhissi committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9836475 View commit details
    Browse the repository at this point in the history