Fix rdspec and protectedpvcs condition #1605
Open
+294
−246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 24, 2024 10:40
Fix an issue where the VRG resource was frequently updated, causing the RDSpec to alternate between an empty and non-empty list. This behavior directly impacted failover and relocation. If the list was empty during these actions, PVC restore was skipped, leading to incomplete recovery. Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
This commit modifies the utility function that creates the ManifestWork to return an additional value indicating the last operation result alongside the error. The result can be one of three values: created, updated, or none. This change is needed to track whether the ManifestWork resource was newly created, updated, or left unchanged. Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
In certain edge cases, ProtectedPVCs may fail to add the PVsRestored condition permanently, causing the relocate process to get stuck in the WaitForReadiness progression. Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes critical fixes for Cephfs workloads that occasionally caused the relocation to stall forever in the WaitForReadiness progression.
Key Changes:
Fix for RDSpec List Alternation
Addressed an issue where frequent VRG resource updates caused the RDSpec list to alternate between empty and non-empty list. This inconsistency was leading to incomplete PVC restores during failover or relocation, halting the recovery process.
Fix for ProtectedPVC
PVsRestoredConditionIn certain edge cases, ProtectedPVCs were failing to add the PVsRestored condition permanently, which caused the relocate process to get stuck in the WaitForReadiness progression. This fix ensures the condition is consistently applied, preventing the relocation from stalling.
Refactor of ManifestWork Creation Function
The utility function that creates ManifestWork has been refactored to return the last operation result (created, updated, or none) alongside any errors. This change allows tracking of whether a ManifestWork resource was newly created, updated, or left unchanged.
Fixes Bug: 2319334