SDLOG_ALGORITHM - AES option not implemented #23816
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
reviewed
Oct 16, 2024
jlaitine
approved these changes
Oct 16, 2024
|
Thanks @jlaitine - @julianoes I can ignore this clang error right? I.e. not related to my change? |
dagar
reviewed
Oct 16, 2024
Co-authored-by: Daniel Agar <daniel@agar.ca>
julianoes
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the AES option to
SDLOG_ALGORITHMparameter is a placeholder for a desirable implementation.However there is no way to know that unless you know that ....
So this adds the words
(Not implemented)after the parameter.@jlaitine Can you confirm the statement and the solution here?
This fell out of PX4/PX4-user_guide#3401