docker: pass $DISPLAY variable and enable X11 forwarding #23559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Martin-Schlodinski
changed the title
mrpollo
previously approved these changes
Aug 16, 2024
dagar
reviewed
Aug 19, 2024
Co-authored-by: Daniel Agar <daniel@agar.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solved Problem
When using the
docker_run.shit wasn't possible to start Gazebo without modifying the parameters passed todocker runinside the script.This PR allows running Gazebo out of the box without any manual file changes.
Solution
DISPLAYenvironment to dockerContext