-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nathan permissions merge #931
Conversation
…unityGlobal/HighestGoodNetworkApp into nathan_permissions_merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should follow the naming convention for components.
src/components/UserProfile/TeamsAndProjects/AddProjectPopup.jsx
Outdated
Show resolved
Hide resolved
src/components/UserProfile/TeamsAndProjects/AddProjectPopup.jsx
Outdated
Show resolved
Hide resolved
As far as it is good on the local site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nathanah,
I have tested your PR and everything works great except for create user. When I click user management -> create new user, the page became blank. (I tried to use different roles like Admin or Owner but they both behaved like this.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have done my best to check everything, everything looks fine except for I can not found permission management under Other links tab. I think you should fix that
MyRecord_20230810114255.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good as far as I have checked. A lot of useful changes here. Nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nathanah , I've tested this PR and everything looks good as the development branch.
Owner, admin and volunteer accounts have been tested on this PR. Owner can see permission list but admin and volunteer cannot. I can also use owner and admin accounts to create new users, new teams and new projects and edit them.
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
volunteer account functions as it should. Doesn't have access to different areas that it shouldn't.
admin & owner account seems to have the exact same permissions as the volunteers except for on the tasks section of the dashboard. I checked the redux state, and it seems they should be able to. However, I haven't gone into the code to try and diagnose why this isn't occurring since I'm not familiar with that area of the codebase.
admin should be able to pause people:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nathanah, I have tested the PR using admin and owner account. There are no breaking changes and the app works as usual when I am navigating through different pages.
Logged in as admin
HGN.APP.-.Google.Chrome.2023-08-16.15-39-46.mp4
Logged in as owner
HGN.APP.-.Google.Chrome.2023-08-16.15-46-33.mp4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functions well in subsequent re-reviews with pull requesters guidance. Was able to clear up the reports and other links issue by running npm run build. Great Job and thanks for your patience.
13bb657
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes remained consistent after merge conflict resolved. Everything functions as it should
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nathanah ,
I read all the comments and tested the PR. App runs normally. The above requested changes have been resolved.
Permissions management tab is seen
Able to navigate and access reports and other links(can create user too)
Description
Fixes #6 (HIGH) Verify that permissions are implemented on the back-end and not just the front-end.
Permissions were split into front-end permissions and back-end permissions with some systems designed to accommodate this. This PR merges both permission sets into one so it's easier to make sure all permissions have relevant security checks implemented.
Related PRS (if any):
This frontend PR is related to the #416 backend PR.
OneCommunityGlobal/HGNRest#416
Main changes explained:
How to test:
npm install
and...
to run this PR locallyScreenshots or videos of changes:
Everything should look the same other than the code.
Note:
If someone wants to help with unit testing, that would be appreciated. I'm considering it out of the scope of this PR though.