Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nathan permissions merge #416

Merged
merged 10 commits into from
Aug 21, 2023
Merged

Conversation

nathanah
Copy link
Contributor

@nathanah nathanah commented Jun 21, 2023

Description

Fixes #6 (HIGH) Verify that permissions are implemented on the back end and not just the front end.
See front-end PR #

Related PRS (if any):

This backend PR is related to the #931 frontend PR.
OneCommunityGlobal/HighestGoodNetworkApp#931

Main changes explained:

  • Updated createInitialPermissions to combine front-end and back-end permissions into a single permission set.
  • Update rolesController.js, taskController.js, teamController.js, and userProfileController.js to have permissions set up.
  • Updated role.js to use different db collection (to not delete data for current system while still testing. can clean up old permissions in a later PR.)
  • Updated permissions.js to only check one set of permissions.

How to test:

  1. check into current branch
  2. do npm install and ... to run this PR locally
  3. The front-end should work the same.

Screenshots or videos of changes:

Everything should look the same other than the code.

@nathanah nathanah requested a review from EvianTan July 23, 2023 21:57
Copy link

@ThapeloMasasa ThapeloMasasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on the frontend

Copy link

@DavidC0126 DavidC0126 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on the frontend PR#931.

Copy link
Contributor

@Abiddy Abiddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left comment in the FE PR.

Copy link

@winghojackyli winghojackyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nathanah , I've tested this PR along with frontend #931 PR. Approval with comments left here OneCommunityGlobal/HighestGoodNetworkApp#931 (review)

Copy link

@veronicacheng2 veronicacheng2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nathanah, I have tested this PR together with #931. Comments left there.

@one-community one-community merged commit bd59a51 into development Aug 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants