Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][15.0] web_notify #2176

Closed
wants to merge 51 commits into from
Closed

[MIG][15.0] web_notify #2176

wants to merge 51 commits into from

Commits on Apr 28, 2022

  1. New module web_notify 

    This technical module allows you to send instant notification messages from the server to the user in live.
    @lmignon @em230418
    lmignon authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    9994a82 View commit details
    Browse the repository at this point in the history

  2. [MIG] Make modules uninstallable

    @pedrobaeza @em230418
    pedrobaeza authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    0a8172f View commit details
    Browse the repository at this point in the history

  3. [MIG] Migration started web_notify

    @JayVora-SerpentCS @em230418
    JayVora-SerpentCS authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    2d7bdf8 View commit details
    Browse the repository at this point in the history

  4. [FIX] Return result of super of show_application

    @adrienpeiffer @em230418
    adrienpeiffer authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    d0721e9 View commit details
    Browse the repository at this point in the history

  5. Update web_client.js

    @JayVora-SerpentCS @em230418
    JayVora-SerpentCS authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    edbdda9 View commit details
    Browse the repository at this point in the history

  6. OCA Transbot updated translations from Transifex

    @oca-transbot @em230418
    oca-transbot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    2dadd89 View commit details
    Browse the repository at this point in the history

  7. [10.0][FIX] web_notify tests: Fix an arg check 

    Fix a check when comparing a user count with items within a mock call.

The previous method was succeeding by pure luck because OCA test
databases contain 2 users, which happens to be the amount of items
within a mock "call_args" (it contains args + kwargs).
    @houzefa-abba @em230418
    houzefa-abba authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    ae266fc View commit details
    Browse the repository at this point in the history

  8. [MIG] web_notify: Migration to 11.0 

    - Use the 'session' class of the JS Framework (session no lounger bound
to web client)
- Test change: compare emitted & received messages based on content, not
order. Using string comparison raises false positives.
    @bouvyd @em230418
    bouvyd authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    54ee4eb View commit details
    Browse the repository at this point in the history

  9. [UPD] Update web_notify.pot

    @oca-travis @em230418
    oca-travis authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    5081c47 View commit details
    Browse the repository at this point in the history

  10. Translated using Weblate (Portuguese (Brazil)) 

    Currently translated at 100,0% (5 of 5 strings)

Translation: web-11.0/web-11.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/pt_BR/
    @em230418
    Rodrigo Macedo authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    8e3dd99 View commit details
    Browse the repository at this point in the history

  11. Translated using Weblate (Danish) 

    Currently translated at 40.0% (2 of 5 strings)

Translation: web-11.0/web-11.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/da/
    @hhgabelgaard @em230418
    hhgabelgaard authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    9a26cff View commit details
    Browse the repository at this point in the history

  12. Prevent to send web notifications to other users 

    Only the admin user (sudo) is allowed to send notifications to other
users. The normal users can only send notifications to themselves.

This is to prevent attackers to craft malicious notifications and send
them to other users using RPC.

Correction based on the idea of @hbrunn
    @guewen @em230418
    guewen authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    716a8a5 View commit details
    Browse the repository at this point in the history

  13. [UPD] Update web_notify.pot

    @oca-travis @em230418
    oca-travis authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    8ee79f7 View commit details
    Browse the repository at this point in the history

  14. [MIG] web_notify: Migration to 12.0 

    Add self-test buttons in demo environment,
Updated readme to show how to test it.
Add buttons to users form
Do not rely on SUPERUSER_ID and avoid getattr usage
    @aitorbouzas @em230418
    aitorbouzas authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    cbadea0 View commit details
    Browse the repository at this point in the history

  15. [FIX] web_notify: Update readme

    @aitorbouzas @em230418
    aitorbouzas authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    f388b62 View commit details
    Browse the repository at this point in the history

  16. [UPD] Update web_notify.pot

    @oca-travis @em230418
    oca-travis authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    888651a View commit details
    Browse the repository at this point in the history

  17. Update translation files 

    Updated by Update PO files to match POT (msgmerge) hook in Weblate.
    @oca-transbot @em230418
    oca-transbot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    f3c60bb View commit details
    Browse the repository at this point in the history

  18. [UPD] README.rst

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    3c2e494 View commit details
    Browse the repository at this point in the history

  19. [12.0] web_notify: improve popup UI (OCA#1231) 

    * [ADD]: all available bootstrap notifications (success/danger/warning/info/default)
* [IMP] use black color for text for default notification.
* [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
    @shepilov-vladislav @em230418
    shepilov-vladislav authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    f5f55ab View commit details
    Browse the repository at this point in the history

  20. [UPD] README.rst

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    6c81581 View commit details
    Browse the repository at this point in the history

  21. [UPD] Update web_notify.pot

    @oca-travis @em230418
    oca-travis authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    ccd94c4 View commit details
    Browse the repository at this point in the history

  22. Update translation files 

    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-12.0/web-12.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/
    @oca-transbot @em230418
    oca-transbot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    21c4915 View commit details
    Browse the repository at this point in the history

  23. Update translation files 

    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-12.0/web-12.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/
    @oca-transbot @em230418
    oca-transbot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    90c9d1d View commit details
    Browse the repository at this point in the history

  24. [FIX] web_notify attempt to fix void messages (OCA#1249) 

    It seems besides the custom channels provided in this addon it also catches messages from other channels. E.g. in this case it seems the void popup is triggered by these activity creation bus messages.

**Steps to reproduce**

Odoo commit: could reproduce on 5e8b667951 and 4da82776ff
OCA/web commit: 2465278

* Install crm and web_notify modules
* Create an activity for yourself (tried for admin user)
* Empty popup appears

**Attempt to solve**

It seems the bus handles all messages non exclusively. I've hacked in a conditional to handle only messages from web_notify addon, but its unclear wether this does not break something else.
    @kkarolis @em230418
    kkarolis authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    f316ade View commit details
    Browse the repository at this point in the history

  25. [UPD] README.rst

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    683d742 View commit details
    Browse the repository at this point in the history

  26. Translated using Weblate (Portuguese (Brazil)) 

    Currently translated at 100.0% (18 of 18 strings)

Translation: web-12.0/web-12.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/pt_BR/
    @em230418
    Rodrigo Macedo authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    b9f5d4c View commit details
    Browse the repository at this point in the history

  27. Added translation using Weblate (Chinese (Simplified))

    @liweijie0812 @em230418
    liweijie0812 authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    1ce37f5 View commit details
    Browse the repository at this point in the history

  28. Translated using Weblate (Chinese (Simplified)) 

    Currently translated at 100.0% (18 of 18 strings)

Translation: web-12.0/web-12.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/zh_CN/
    @liweijie0812 @em230418
    liweijie0812 authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    124c5db View commit details
    Browse the repository at this point in the history

  29. [REF] web_notify: Black python code

    @em230418
    laurent.corron authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    d229fb0 View commit details
    Browse the repository at this point in the history

  30. [MIG] web_notify: Migration to 13.0

    @em230418
    laurent.corron authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    bbb0e14 View commit details
    Browse the repository at this point in the history

  31. [UPD] Update web_notify.pot

    @oca-travis @em230418
    oca-travis authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    46fc984 View commit details
    Browse the repository at this point in the history

  32. [UPD] README.rst

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    af82393 View commit details
    Browse the repository at this point in the history

  33. Update translation files 

    Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-13.0/web-13.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_notify/
    @oca-transbot @em230418
    oca-transbot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    c607e6b View commit details
    Browse the repository at this point in the history

  34. [IMP] pre-commit run after update 

    Includes some manual fixes to silent ESLint warnings.
    @em230418
    Jairo Llopis authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    8a8d4df View commit details
    Browse the repository at this point in the history

  35. [MIG] web_timeline: Finish migration to 13.0

    @Tardo @em230418
    Tardo authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    6716468 View commit details
    Browse the repository at this point in the history

  36. [UPD] README.rst

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    89b66d5 View commit details
    Browse the repository at this point in the history

  37. [UPD] README.rst

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    9b03307 View commit details
    Browse the repository at this point in the history

  38. Translated using Weblate (German) 

    Currently translated at 100.0% (18 of 18 strings)

Translation: web-13.0/web-13.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_notify/de/
    @didierdonze @em230418
    didierdonze authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    31fcd00 View commit details
    Browse the repository at this point in the history

  39. [IMP] web_notify: add channels only if not done already

    @jjscarafia @em230418
    jjscarafia authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    7e63d76 View commit details
    Browse the repository at this point in the history

  40. web_notify 13.0.1.0.1

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    36098d8 View commit details
    Browse the repository at this point in the history

  41. [IMP] web_notify: black, isort, prettier

    @kevinkhao @em230418
    kevinkhao authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    e30f19d View commit details
    Browse the repository at this point in the history

  42. [14.0][MIG] web_notify: Migration to version 14.0

    @kevinkhao @em230418
    kevinkhao authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    7d59d67 View commit details
    Browse the repository at this point in the history

  43. [UPD] Update web_notify.pot

    @oca-travis @em230418
    oca-travis authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    0bc8cf6 View commit details
    Browse the repository at this point in the history

  44. [UPD] README.rst

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    ce595b2 View commit details
    Browse the repository at this point in the history

  45. Added translation using Weblate (Dutch)

    @bosd @em230418
    bosd authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    402334a View commit details
    Browse the repository at this point in the history

  46. Translated using Weblate (Dutch) 

    Currently translated at 42.8% (9 of 21 strings)

Translation: web-14.0/web-14.0-web_notify
Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_notify/nl/
    @bosd @em230418
    bosd authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    ee74ba1 View commit details
    Browse the repository at this point in the history

  47. web_notify: bump dev status 

    It exists since many version and is actively maintained.
    @sbidoul @em230418
    sbidoul authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    505d401 View commit details
    Browse the repository at this point in the history

  48. [UPD] README.rst

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    7d1fd63 View commit details
    Browse the repository at this point in the history

  49. web_notify 14.0.1.0.1

    @OCA-git-bot @em230418
    OCA-git-bot authored and em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    d84f6fd View commit details
    Browse the repository at this point in the history

  50. [IMP] web_notify: black, isort, prettier

    @em230418
    em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    86af31d View commit details
    Browse the repository at this point in the history

  51. [MIG] web_notify: Migration to 15.0 

    Porting notes:
1. Removed notify_default, since it does not pass validation in [1]
2. Modifications to notificaation widgets are removed in prefer of original widget implementation
3. Odoo improved notification usage in [2], so no need to add extra channels that depend on user's id

[1] https://github.com/odoo/odoo/blob/21be7ca0c9eef18184d06755ff83337be1e4752e/addons/web/static/src/core/notifications/notification.js#L49
[2] odoo/odoo@543af27
    @em230418
    em230418 committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    d4d1ffc View commit details
    Browse the repository at this point in the history