[MIG][15.0] web_notify #2176
Closed
[MIG][15.0] web_notify #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
em230418
force-pushed
the
15.0-mig-web_notify
branch
from
9549393
to
c7557d2
Compare
JrAdhoc
reviewed
Apr 26, 2022
|
Checked why codecov did not cover tests. https://github.com/OCA/web/pull/2176/checks?check_run_id=5770875580 |
em230418
force-pushed
the
15.0-mig-web_notify
branch
from
c7557d2
to
5b6c89d
Compare
This technical module allows you to send instant notification messages from the server to the user in live.
Fix a check when comparing a user count with items within a mock call. The previous method was succeeding by pure luck because OCA test databases contain 2 users, which happens to be the amount of items within a mock "call_args" (it contains args + kwargs).
- Use the 'session' class of the JS Framework (session no lounger bound to web client) - Test change: compare emitted & received messages based on content, not order. Using string comparison raises false positives.
Currently translated at 100,0% (5 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/pt_BR/
Currently translated at 40.0% (2 of 5 strings) Translation: web-11.0/web-11.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-11-0/web-11-0-web_notify/da/
Only the admin user (sudo) is allowed to send notifications to other users. The normal users can only send notifications to themselves. This is to prevent attackers to craft malicious notifications and send them to other users using RPC. Correction based on the idea of @hbrunn
Add self-test buttons in demo environment, Updated readme to show how to test it. Add buttons to users form Do not rely on SUPERUSER_ID and avoid getattr usage
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
* [ADD]: all available bootstrap notifications (success/danger/warning/info/default) * [IMP] use black color for text for default notification. * [FIX] reverted require string for `bus.Longpolling` and rename `on_message_received` to `on_message` to prevent collisions.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-12.0/web-12.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-12-0/web-12-0-web_notify/
It seems besides the custom channels provided in this addon it also catches messages from other channels. E.g. in this case it seems the void popup is triggered by these activity creation bus messages. **Steps to reproduce** Odoo commit: could reproduce on 5e8b667951 and 4da82776ff OCA/web commit: 2465278 * Install crm and web_notify modules * Create an activity for yourself (tried for admin user) * Empty popup appears **Attempt to solve** It seems the bus handles all messages non exclusively. I've hacked in a conditional to handle only messages from web_notify addon, but its unclear wether this does not break something else.
Includes some manual fixes to silent ESLint warnings.
Currently translated at 100.0% (18 of 18 strings) Translation: web-13.0/web-13.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-13-0/web-13-0-web_notify/de/
Currently translated at 42.8% (9 of 21 strings) Translation: web-14.0/web-14.0-web_notify Translate-URL: https://translation.odoo-community.org/projects/web-14-0/web-14-0-web_notify/nl/
It exists since many version and is actively maintained.
em230418
force-pushed
the
15.0-mig-web_notify
branch
from
5b6c89d
to
13d6605
Compare
Porting notes: 1. Removed notify_default, since it does not pass validation in [1] 2. Modifications to notificaation widgets are removed in prefer of original widget implementation 3. Odoo improved notification usage in [2], so no need to add extra channels that depend on user's id [1] https://github.com/odoo/odoo/blob/21be7ca0c9eef18184d06755ff83337be1e4752e/addons/web/static/src/core/notifications/notification.js#L49 [2] odoo/odoo@543af27
em230418
force-pushed
the
15.0-mig-web_notify
branch
from
13d6605
to
d4d1ffc
Compare
|
Is this PR ready for review? |
|
You can review functionality. Unit-tests are not ready. |
JosDeGraeve
reviewed
May 6, 2022
| self, type_message, message=DEFAULT_MESSAGE, title=None, sticky=False | ||
| ): | ||
| # pylint: disable=protected-access | ||
| if not self.env.user._is_admin() and any( |
There was a problem hiding this comment.
This allows to use sudo() to send a message to any user.
Suggested change
| if not self.env.user._is_admin() and any( | |
| if not (self.env.su or self.env.user._is_admin()) and any( |
JosDeGraeve
reviewed
May 6, 2022
matiasperalta1
approved these changes
Jun 24, 2022
|
Closing in favour of #2381 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porting notes:
[1] https://github.com/odoo/odoo/blob/21be7ca0c9eef18184d06755ff83337be1e4752e/addons/web/static/src/core/notifications/notification.js#L49
[2] odoo/odoo@543af27