Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiqSmartProxyWorker not running in Podified #20497

Merged
merged 1 commit into from
Aug 31, 2020
Merged

MiqSmartProxyWorker not running in Podified #20497

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions app/models/miq_smart_proxy_worker.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
class MiqSmartProxyWorker < MiqQueueWorkerBase
include MiqWorker::ReplicaPerWorker

require_nested :Runner

self.required_roles = ["smartproxy"]
self.default_queue_name = "smartproxy"

def self.supports_container?
true
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if this was an oversight or there was a reason for the smart proxy worker not running on pods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this worker, only the cockpit worker doesn't support containers:

>> MiqWorker.leaf_subclasses.reject(&:supports_container?).map(&:name)
=> ["MiqCockpitWsWorker"]

Maybe better to change the default in the base class to true and just say not supported in the cockpit worker?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Maybe we didn't enable the smart proxy because we didn't know if we could scan things in pods?

ManageIQ/manageiq-pods#595
ManageIQ/manageiq-pods#596

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to support it by default in all workers other than cockpit and possibly this one, yeah, I agree, we should default to support in the base class and have them disable it in those one or two classes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah if that's the reason then that's only RHV fleecing the rest are fine (this happened to be Azure SSA)

Copy link
Member Author

@agrare agrare Aug 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any discussion on #15884 about which workers to enable and why unfortunately


def self.kill_priority
MiqWorkerType::KILL_PRIORITY_SMART_PROXY_WORKERS
end
Expand Down