MiqSmartProxyWorker not running in Podified #20497
Conversation
| require_nested :Runner | ||
|
|
||
| self.required_roles = ["smartproxy"] | ||
| self.default_queue_name = "smartproxy" | ||
|
|
||
| def self.supports_container? | ||
| true | ||
| end |
There was a problem hiding this comment.
I'm not sure if this was an oversight or there was a reason for the smart proxy worker not running on pods
There was a problem hiding this comment.
Other than this worker, only the cockpit worker doesn't support containers:
>> MiqWorker.leaf_subclasses.reject(&:supports_container?).map(&:name)
=> ["MiqCockpitWsWorker"]
Maybe better to change the default in the base class to true and just say not supported in the cockpit worker?
There was a problem hiding this comment.
Good question. Maybe we didn't enable the smart proxy because we didn't know if we could scan things in pods?
There was a problem hiding this comment.
If we want to support it by default in all workers other than cockpit and possibly this one, yeah, I agree, we should default to support in the base class and have them disable it in those one or two classes.
There was a problem hiding this comment.
Yeah if that's the reason then that's only RHV fleecing the rest are fine (this happened to be Azure SSA)
There was a problem hiding this comment.
I don't see any discussion on #15884 about which workers to enable and why unfortunately
|
Checked commit agrare@3acd8ac with ruby 2.6.3, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
…in_podified MiqSmartProxyWorker not running in Podified (cherry picked from commit ff7f15b)
|
Jansa backport details: |
SmartState jobs aren't getting started on podified, no MiqSmartProxyWorker is running so the start signal never gets run.