Delight for RAIL #3
Conversation
There was a problem hiding this comment.
Thanks a lot @sylvielsstfr , I will need to install it and run it to understand the codebase better. In the meantime there are a few essentially cosmetic requests. We probably need to discuss the general interfacing to RAIL as well
| @@ -0,0 +1,2 @@ | |||
| global-include *.res | |||
| global-include *.dat | |||
| @@ -148,8 +191,11 @@ def parseParamFile(fileName, verbose=True, catFilesNeeded=True): | |||
| config.get('Other', 'confidenceLevels').split(' ')] | |||
|
|
|||
| if verbose: | |||
There was a problem hiding this comment.
why is there still a verbose condition if you use a logger?
| @@ -2,8 +2,14 @@ | |||
|
|
|||
| import numpy as np | |||
|
|
|||
| from scipy.misc import logsumexp | |||
| #from scipy.misc import logsumexp | |||
There was a problem hiding this comment.
delete commented out changes
| @@ -0,0 +1,263 @@ | |||
|
|
|||
There was a problem hiding this comment.
add docstrings to explain this new code
| @@ -0,0 +1,232 @@ | |||
|
|
|||
There was a problem hiding this comment.
add docstrings to explain this new code
| # if make_plot, save images | ||
| # | ||
| # output file : band + '_gaussian_coefficients.txt' | ||
| ##################################################################################################### |
There was a problem hiding this comment.
why is there a code fitting band filters with a gaussian mixtures here and in interface/rails?
| # | ||
| # output file : sed_name + '_fluxredshiftmod.txt' | ||
| ###################################################################################################### | ||
|
|
There was a problem hiding this comment.
likewise, isn't this a duplicate?
| #package_data={'delightdata': ['data/BROWN_SEDs/*.dat', 'data/CWW_SEDs/*.dat','data/FILTERS/*.res']}, | ||
| package_data={'': extra_files}, | ||
| #include_package_data = True, | ||
|
|
There was a problem hiding this comment.
remove commented out code
| ## Utilities | ||
|
|
||
| - **utils.py** : Library of IO inside RAIL used in **convertDESCcat.py** for reading DESC dataset. (It means it has been copied from RAIL to Delight bacause it is not possible to make cross dependence between these packages (Delight depending on RAIL and RAIL depending on Delight). | ||
|
|
There was a problem hiding this comment.
right but copying the codebase is not a solution either. Like in the comment above, I think that the code relying on it needs to live in rail, not in Delight
| - **convertDESCcat.py**: Convert DESC PhotoZ dataset into ascii files readable by Delight. For now, only files with hdf5 format are used. | ||
|
|
||
| - **getDelightRedshiftEstimation.py**: Retrieve results on PhotoZ estimation of Delight for RAIL. | ||
|
|
There was a problem hiding this comment.
if by interface we mean here "running with rail", then this code probably needs to live in RAIL
This should make the inclusion of Delight in RAIL cleaner to initiate and maintain.