Issue/49/delight #57
Issue/49/delight #57
Conversation
…ig file is created locally
Codecov Report
@@ Coverage Diff @@
## master #57 +/- ##
===========================================
- Coverage 97.58% 22.94% -74.64%
===========================================
Files 8 28 +20
Lines 331 1970 +1639
===========================================
+ Hits 323 452 +129
- Misses 8 1518 +1510
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
@sylvielsstfr ok very first look at it. There is a lot to digest! Would it be possible to add some basic unit tests so that we clear some of the codecov warnings, and we get to see a bit better the basic functionalities?
|
|
||
| - python setup.py build_ext --inplace | ||
| - python setup.py install --user | ||
|
|
There was a problem hiding this comment.
in DESC we are advocating to avoid --user as it is extremely fragile. If the packages are not conda installable, one should still work in a conda env and run pip within this env, without --user
| - **Delight/interfaces/rail** | ||
|
|
||
| (To avoid too much code inside RAIL) | ||
|
|
There was a problem hiding this comment.
It is probably not a good idea even if it is a lot of code. And the copying of the utils.py file in Delight, which anyway is going to be deprecated, is a red flag.
| [Bands] | ||
| names: lsst_u lsst_g lsst_r lsst_i lsst_z lsst_y | ||
| directory: /Users/sylvie/MacOSX/GitHub/LSST/Delight/data/FILTERS | ||
| numCoefs: 15 |
There was a problem hiding this comment.
Problem with personal path here
|
|
||
| [Templates] | ||
| directory: /Users/sylvie/MacOSX/GitHub/LSST/Delight/data/CWW_SEDs | ||
| names: El_B2004a Sbc_B2004a Scd_B2004a SB3_B2004a SB2_B2004a Im_B2004a ssp_25Myr_z008 ssp_5Myr_z008 |
rail/estimation/algos/delightPZ.py
Outdated
| from interfaces.rail.convertDESCcat import convertDESCcat # convert DESC input file into Delight format | ||
| from interfaces.rail.convertDESCcat import * # convert DESC input file into Delight format | ||
| from interfaces.rail.calibrateTemplateMixturePriors import * | ||
| from interfaces.rail.getDelightRedshiftEstimation import * |
There was a problem hiding this comment.
We probably need to move most of these to RAIL
|
Are these changes being reflected in the DESC fork of Delight? I think it would be easier to make the changes there and then have RAIL just install and call from that code, no? |
I think it is time to proceed to do a merge of delightPZ in master.
The merging is purely functionnal. It means Delight hyper parameters are not optimized for test-DC2 dataset. I will need RAIL metrics for this or doing something else.
Note to integrate Delight with DESC it is necessary to review https://github.com/sylvielsstfr/Delight
A first step is to install the Delight branch desc_rail here https://github.com/sylvielsstfr/Delight/tree/desc_rail in
https://github.com/LSSTDESC
Then most of the work of interfacing Delight with RAIL can be found in:
https://github.com/sylvielsstfr/Delight/tree/desc_rail/interfaces/rail
where it is possible to read the README.md file.
Let me know when you are ready for presenting/introducing how all this stuff works.
Sylvie