Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAML2 ECP login support #55

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cemiarni
Copy link

It requires this pull request: IdentityPython/pysaml2#407

@knaperek
Copy link
Collaborator

Hi @cemiarni, welcome and thanks for your contribution.

Let's wait until your PR is accepted in pysaml2 and then come back here.

@knaperek
Copy link
Collaborator

Hi @cemiarni, would you please rebase?

@cemiarni cemiarni force-pushed the master branch 2 times, most recently from 244b1bf to 2ca6df3 Compare October 13, 2017 18:55
@cemiarni
Copy link
Author

I've done it. It works with pysaml2 4.5.0, that's also done.

@knaperek
Copy link
Collaborator

Hi @cemiarni, would you please rebase again? The Python 3.3 error catched by Travis has now been fixed in our master. Thanks.

@cemiarni
Copy link
Author

Done.

@peppelinux
Copy link
Member

This is a good PR, it is the case to resolve the conflicts for the next release

@peppelinux
Copy link
Member

Hi @cemiarni
I never used SOAP in SAML2 and never used SAML1 but I see that your PR is a good piece of code and if you're still interested we could consider this in the next release. Let us know if there would be the possibility to merge this after resolving the conflicts

@peppelinux peppelinux force-pushed the master branch 6 times, most recently from 0e72c45 to 29ad753 Compare April 4, 2021 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants