rename edge to mapping #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmungall
approved these changes
Jun 4, 2024
cmungall
reviewed
Jun 4, 2024
| EdgeDeletion, | ||
| Mapping, |
There was a problem hiding this comment.
Mapping was changed here. Should it be Edge on that line?
twhetzel
commented
Jun 5, 2024
twhetzel
commented
Jun 5, 2024
|
@hrshdhgd can you take over sorting out what needs to be fixed here? |
Yes, thank you so much for getting this started. I got this from here. |
|
This also fixes #732 Avoids duplication of changes being listed in the markdown table. |
cmungall
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added updates based on: #735 (comment)
There are helper methods that still refer to
Edge, e.g. "_generate_relation_changes". I'm not sure if those also need to change.