-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runoak diff erroneously names "relationships" --> "mappings" in markdown summary #735
Comments
So there might be some misunderstanding on my part or a bug in code. The table created under Similarly
Code from differ_interface: ontology-access-kit/src/oaklib/interfaces/differ_interface.py Lines 269 to 305 in 41c1d95
Code from simpleobo: ontology-access-kit/src/oaklib/implementations/simpleobo/simple_obo_implementation.py Lines 900 to 910 in 41c1d95
ontology-access-kit/src/oaklib/implementations/simpleobo/simple_obo_implementation.py Lines 483 to 497 in 41c1d95
Thoughts @cmungall |
edge is very generic in KGCL, it encompasses relationships and mappings |
OK, I misspoke. edges is KGCL are the same as edges in OAK this code is not quite right: if mappings_added_set:
for mapping in mappings_added_set:
predicate, xref = mapping
edge_created = EdgeCreation(
id=_gen_id(),
subject=entity,
predicate=predicate,
object=xref,
)
yield edge_created
if mappings_removed_set:
for mapping in mappings_removed_set:
predicate, xref = mapping
deleted_edge = EdgeDeletion(
id=_gen_id(),
subject=entity,
predicate=predicate,
object=xref,
)
yield deleted_edge
if mapping_changed_set:
for changes in mapping_changed_set:
object, new_predicate, old_predicate = changes
edge_change = EdgeChange(
id=_gen_id(),
about_edge=Edge(subject=entity, predicate=old_predicate, object=object),
old_value=old_predicate,
new_value=new_predicate,
)
yield edge_change simply change |
Fixed by #775 |
The "Relation ship added" section is erroneously called "Mappings added".
Example: obophenotype/human-phenotype-ontology#10446 (comment)
The text was updated successfully, but these errors were encountered: