Quality-of-life and typo fixes in several files. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit/pull request fixes small typos in several files and makes small changes to behavior that this developer found useful. Colorized text (Red for failure, green for unlocked) when LinuxPBA runs modified: LinuxPBA/UnlockSEDs.cpp Added "sleep 5" after LinuxPBA runs, so that users can view unlock success or failure modified: images/buildroot/32bit/overlay/etc/init.d/S99PBA.sh modified: images/buildroot/64bit/overlay/etc/init.d/S99PBA.sh Typo fixes as well as changes to move "clone buildroot" into the getresources script modified: images/buildpbaroot modified: images/buildrescue modified: images/getresources Typo fixes, including all the changes from Pull Request 254 (jessehui) modified: linux/PSIDRevert_LINUX.txt modified: windows/PSIDRevert_WINDOWS.txt
Typo fixes (parameter) in DtaDevOpal.cpp and DtaOptions.h QOL/nit bug fixes in DtaOptions.cpp: - Command line option --enableUser to SEDutil had incorrect number of parameters (was 2 now 3) - Command line option --enableUser wasn't documented as part of the "usage" printout
…scue
Several SED vendors, specifically including Seagate and Micron, provide Linux CLI-based utilities
to manage their SEDs. This update to buildrescue provides an easy way to insert those utilities
into the Rescue{32,64} images that are produced, so they're available when Rescue becomes a need.
Create a subdirectory sedutil/images/vendor and copy any CLI utilities there, and they'll be
available under /usr/vendor on the Rescue image.
Additional notes are embedded as comments in the buildrescue script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit/pull request fixes small typos in several files and makes small changes to behavior
that this developer found useful.
Colorized text (Red for failure, green for unlocked) when LinuxPBA runs
modified: LinuxPBA/UnlockSEDs.cpp
Added "sleep 5" after LinuxPBA runs, so that users can view unlock success or failure
(particularly useful with multiple disks being unlocked)
modified: images/buildroot/32bit/overlay/etc/init.d/S99PBA.sh
modified: images/buildroot/64bit/overlay/etc/init.d/S99PBA.sh
Typo fixes as well as changes to move "clone buildroot" into the getresources script
modified: images/buildpbaroot
modified: images/buildrescue
modified: images/getresources
Typo fixes, including all the changes from Pull Request 254 (jessehui)
modified: linux/PSIDRevert_LINUX.txt
modified: windows/PSIDRevert_WINDOWS.txt