Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: --enableUser is implemented but not included in usage note #16

Closed
oom-is opened this issue Oct 27, 2019 · 1 comment
Closed

Bug: --enableUser is implemented but not included in usage note #16

oom-is opened this issue Oct 27, 2019 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@oom-is
Copy link
Owner

oom-is commented Oct 27, 2019

The command-line option to sedutil-cli for --enableUser is fully implemented, and appears in the Wiki pages, but doesn't show up when the "usage" info is displayed (e.g. sedutil-cli with no further arguments). File to be fixed is Common/DtaOptions.cpp

Further, just in case anyone looks closely: There's a bug later in the same file where the prototype claims there are only two arguments but then lists three.
BEGIN_OPTION(enableuser, 2) OPTION_IS(password) OPTION_IS(userid)
OPTION_IS(device) END_OPTION
(that "2" above should be "3"

This was (correctly but silently) fixed by @CyrilVanErsche as part of his pull request Drive-Trust-Alliance#272 so anyone who wants to use that function but hasn't ingested that CVE pull request needs to fix the number of arguments. Realistically, though, anyone using Opal who wants to use --enableUser probably also wants to include the AddUserToLockingACEs functionality, so it's not clear who would care strongly about a separate fix for the number-of-arguments bug...

@oom-is oom-is added the bug Something isn't working label Oct 27, 2019
@oom-is oom-is self-assigned this Oct 27, 2019
@oom-is
Copy link
Owner Author

oom-is commented Oct 29, 2019

Closing - this has been added to the "QOL-typo-fixes" branch here - although I'm treating it as a bug, I can't make that determination for upstream. It's also in updated Pull Request Drive-Trust-Alliance#307.

This is being integrated into the integ branch along with all other changes.

@oom-is oom-is closed this as completed Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant