Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom Fonts & Skins - Rewording #76
base: main
Are you sure you want to change the base?
Custom Fonts & Skins - Rewording #76
Changes from all commits
2e81c40
14b72ab
fb82bdb
48bbd93
dd7a961
fa4c7cf
7b2be77
b8c51e4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section is honestly kinda useless with the changes you made above. I'd either remove this section entirely or restore it more or less to how it was. Could mention that this section is only for GIMP, which is recommended but not strictly required.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking it over again you should probably mention that this is when converting to Indexed mode, the others of these bullets are talking about the colormap dialog. Maybe just add this to line 58 above since there's no reason not to set the max colors to 16.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer the old version of this paragraph. Also they don't go in a
ui
folder, justfont
in the skin folder.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh, I forgot where I read that you should use the ui folder. I'll do this as a manual commit.