Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Fonts & Skins - Rewording #76

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

NightScript370
Copy link
Member

Specific sections of the customization pages in TWiLight Menu++ could really use an update to accommodate the change of terminology ([sub-]themes -> skins), section off things better or just improve grammar. Here is my attempt but I want to get the community vote before even making this available to merge.

I am done for now, so feel free to review.

@NightScript370 NightScript370 marked this pull request as ready for review November 4, 2022 14:16
@NightScript370
Copy link
Member Author

This PR is ready for review but I would appreciate reviews from lifehacker, Evie & triangle

Copy link
Member

@Epicpkmn11 Epicpkmn11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw sorry if I come off as kinda overbearing or harsh in wiki PR reviews, I just hold the wiki to a relatively high standard in my mind so I like to at least make suggestions when I see things I don't entirely agree with.

My suggestions are just that, suggestions, and should not be taken as required changes, please comment back if you disagree.

pages/_en-US/twilightmenu/custom-dsi-3ds-sfx.md Outdated Show resolved Hide resolved
pages/_en-US/twilightmenu/custom-dsi-3ds-sfx.md Outdated Show resolved Hide resolved
pages/_en-US/twilightmenu/custom-dsi-3ds-skins.md Outdated Show resolved Hide resolved
## Part 2: Editing images
Download and install [GIMP](https://www.gimp.org)
- Other image editors such as Photoshop may work, but GIMP is what will be used in this guide

Once installed, open GIMP and select `Windows` -> `Dockable Dialogs` -> `Colormap`. This opens the colormap dialog, which will be helpful when editing paletted images.

You can now open whichever image you want to edit in GIMP and continue to the section below based on which folder it's in. Note that TWiLight Menu++ is picky about the exact format of the images and it varies by which folder they're in, so make sure to export as the section says.
With the image editor described above, you are now ready to edit any image based from a TWiLight Menu++ skin, as long as the format remains the same from the source specification. They are categorized by folders, each of them being located on the skin root folder.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is honestly kinda useless with the changes you made above. I'd either remove this section entirely or restore it more or less to how it was. Could mention that this section is only for GIMP, which is recommended but not strictly required.

pages/_en-US/twilightmenu/custom-dsi-3ds-skins.md Outdated Show resolved Hide resolved

## Custom fonts
You may put [Custom Fonts](custom-fonts) in the `font` folder for use in the skin. You can also add override fonts for the date & time using `date_time.nftr`, and the console username with `username.nftr`.
Custom fonts can be loaded from skins, whether globally or specific sections (`date_time.nftr`/`username.nftr`). Place them in `ui` -> `font`, according to the selection specified in the "[Custom Fonts](custom-fonts)" page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the old version of this paragraph. Also they don't go in a ui folder, just font in the skin folder.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I forgot where I read that you should use the ui folder. I'll do this as a manual commit.

pages/_en-US/twilightmenu/custom-fonts.md Outdated Show resolved Hide resolved
pages/_en-US/twilightmenu/custom-fonts.md Outdated Show resolved Hide resolved
pages/_en-US/twilightmenu/custom-fonts.md Outdated Show resolved Hide resolved
Copy link
Member

@Epicpkmn11 Epicpkmn11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more things I missed before

pages/_en-US/twilightmenu/custom-dsi-3ds-skins.md Outdated Show resolved Hide resolved
**Note:** Some images in the DSi theme have their palettes overridden based on the user's profile color. If editing the colors of these ensure that the `UserPalette` option for it in the `theme.ini` is set to `0`.
Indexed Images requires an exact count of 16 colors, with the first of which (#0) being transparent (#FF00FF).
- To set the transparent color as the first entry in the colormap, right click the colormap and select `Rearrange Colormap...`. Then, simply move the transparent color to the slot and select `OK`
- If there are over 16 colors, set `Maximum number of colors` to 16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking it over again you should probably mention that this is when converting to Indexed mode, the others of these bullets are talking about the colormap dialog. Maybe just add this to line 58 above since there's no reason not to set the max colors to 16.

pages/_en-US/twilightmenu/custom-dsi-3ds-skins.md Outdated Show resolved Hide resolved
NightScript370 and others added 8 commits April 28, 2023 05:38
- Remove run-on sentence in the beginning
- Introduce the topic by explaining its benefits first rather than just jumping straight into SD card config
- Don't put two filenames immediately next to each other.
- Label both Audacity and ffmpeg for sidebar purposes
Tense change, no single bullet, remove accidentally forgotten line

Co-authored-by: Pk11 <epicpkmn11@outlook.com>
I forgot we could move the word "Example" to the first line

Co-authored-by: Pk11 <epicpkmn11@outlook.com>
Co-authored-by: Pk11 <epicpkmn11@outlook.com>
Oops, sorry for the email spam. I forgot this feature existed.
Almost all of Evie's changes are addressed.

Co-authored-by: Pk11 <epicpkmn11@outlook.com>
Co-authored-by: Pk11 <epicpkmn11@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants