-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use template for pipeline config generation #4160
use template for pipeline config generation #4160
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here, Victor! A few small comments but nothing blocking.
FWIW, and it's probably just the wanna be compiler engineer in me, but I personally feel a lot better when we have some checked in baselines/snapshots of the generated artifacts, especially in cases where the way they get generated is via complex text templating pipelines. I like this because I can quickly see in a PR how the final document is impacted by changes and the tests give me confidence that I didn't actually regress parts of generation.
I may be in the minority here (and I know the baselines are a little frustrating to update at times) - but if you think it would be worthwhile to have a few tests that use the snapshotting technology against some generated pipelines I would not be opposed.
…or-pipeline-config-generation
…or-pipeline-config-generation
Added snapshots |
Repoman Generation ResultsRepoman pushed changes to remotes for the following projects: Project: azd-starter-bicepRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/azd-starter-bicep -b pr/4160 View Changes | Compare Changes Project: todo-csharp-cosmos-sqlRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/4160 View Changes | Compare Changes Project: todo-csharp-sql-swa-funcRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/4160 View Changes | Compare Changes Project: todo-csharp-sqlRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-csharp-sql -b pr/4160 View Changes | Compare Changes Project: todo-java-mongo-acaRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo-aca -b pr/4160 View Changes | Compare Changes Project: todo-java-mongoRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-java-mongo -b pr/4160 View Changes | Compare Changes Project: todo-nodejs-mongo-acaRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/4160 View Changes | Compare Changes Project: todo-nodejs-mongo-aksRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/4160 View Changes | Compare Changes Project: todo-nodejs-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/4160 View Changes | Compare Changes Project: todo-nodejs-mongoRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo -b pr/4160 View Changes | Compare Changes Project: todo-nodejs-mongo-terraformRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/4160 View Changes | Compare Changes Project: todo-python-mongo-acaRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-aca -b pr/4160 View Changes | Compare Changes Project: todo-python-mongo-swa-funcRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/4160 View Changes | Compare Changes Project: todo-python-mongoRemote: azure-samples-stagingBranch: pr/4160You can initialize this project with: azd init -t Azure-Samples/todo-python-mongo -b pr/4160 View Changes | Compare Changes |
…or-pipeline-config-generation
61dd4ea
to
391a724
Compare
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash:
pwsh:
WindowsPowerShell install
MSI install
Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
fix: #4157
Updates azd's pipeline auto-generation to be based on a go-template.
By doing this, the generated pipeline definition has a unique authentication and includes specific configuration like the Aspire workload installation.
This PR fully covers github and azdo for Aspire and non-Aspire projects. Terraform needs more changes which will be covered in a subsequent PR.