For local files: read file completely instead of leaving a dangling open

AllenInstitute · Mar 20, 2024 · 2c3e78a · 2c3e78a
1 parent 1555e7d
commit 2c3e78a
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/src/npc_sync/sync.py b/src/npc_sync/sync.py
@@ -268,12 +268,14 @@ def load(self, path) -> h5py.File:
                 self.dfile = h5py.File(path, "r")
             except OSError:
                 path = npc_io.from_pathlike(path)
-                ffspec_storage_options = {}
-                if path.protocol not in ("", "file"):
-                    ffspec_storage_options["cache_type"] = "first"
-                self.dfile = h5py.File(
-                    path.open(mode="rb", **ffspec_storage_options), "r"
-                )
+                if path.protocol in ("", "file"):
+                    self.dfile = h5py.File(
+                        path.as_posix(), "r"
+                    )
+                else:
+                    self.dfile = h5py.File(
+                        path.open(mode="rb", cache_type="first"), "r"
+                    )
         return self.dfile
 
     @property