Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap_polygons FromLimsSource functionality broken #190

Open
tmchartrand opened this issue Feb 26, 2021 · 1 comment
Open

snap_polygons FromLimsSource functionality broken #190

tmchartrand opened this issue Feb 26, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@tmchartrand
Copy link

tmchartrand commented Feb 26, 2021

Describe the bug
The snap_polygons module has a FromLimsSource option to pull input arguments from LIMS queries, but it refers to outdated code in argschema, failing to run at all. Some minor usability changes will also be helpful in supporting use of this functionality.

To Reproduce
Follow the example usage from the command line:

python -m neuron_morphology.snap_polygons
    --host <lims host> 
    --port <lims port> 
    --user <username> 
    --password <password> 
    --database <lims db> 
    --focal_plane_image_series_id 522408212 # for instance
    --output_json output.json

Expected behavior
Successful run of the module, producing modified polygons and other output.

Actual Behavior
ImportError: cannot import name 'ArgSource' from 'argschema.sources'
(ArgSource should be ConfigurableSource).

Environment (please complete the following information):

  • OS & version: Centos 7
  • Python version 3.7
  • neuron_morphology version: current dev branch

Additional context
It's possible this issue is partly due to using the wrong version of argschema (versions are not specified by tags for that repo), but it occurs for both a pip install from neuron_morphology requirements, and installation from source from commits that seem to be on the correct branch (input_source_3.0a). There are some related mixups in the argschema docs, see AllenInstitute/argschema#106.

Do you want to work on this issue?
Yes, will submit PR shortly

@tmchartrand tmchartrand added the bug Something isn't working label Feb 26, 2021
@wbwakeman
Copy link

includes #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants