Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable absolute depth measurements by saving path length #188

Open
tmchartrand opened this issue Feb 26, 2021 · 0 comments
Open

enable absolute depth measurements by saving path length #188

tmchartrand opened this issue Feb 26, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@tmchartrand
Copy link

Describe the use case that is addressed by this feature.
The functionality in the layered_point_depths module is currently narrowly oriented towards aligning depths onto a reference layer boundary template using normalized depth measurements. Some of the methods could also be useful for other depth-related calculations, like absolute depth (full depth or in layer), but they need some tweaks to enable this.

Describe the solution you'd like
A minimal set of changes would be to have the step_from_node function also return the length of the path traveled to an intersection. This enables user code to make some of the depth calculations without duplicating too much code.

In the long run, it may also be worth incorporating methods that compile the absolute depth info (similar to get_node_intersections), but that can remain user code for now.

Describe alternatives you've considered

Additional context
A full working demonstration of this functionality also requires some fixes to the snap_polygons modules, which I'll file separately.

Do you want to work on this issue?
Yes, will submit PR shortly.

@tmchartrand tmchartrand added the enhancement New feature or request label Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant