Labnotebook querying: Fix querying the NaN sweep with unknown mode #2289
+156
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preparing the labnotebooks for incorporation into Basic.pxp we remove unneeded rows to save space. But we also forgot to update the NOTE_INDEX. So let's fix it up in the preparation routine.
We don't have the NOTE_INDEX since forever so we actually should add an upgrade path for it. While at it, also add some tests.
When we look for data in the NaN sweep, these are the labnotebook entries before the very first sweep and don't care about the entry source type (UNKNOWN_MODE) we did not find anything. The reason is that we are searching from the back for a continous range of entries with the given source type and sweep number. But if we have empty entries at the back of the labnotebook, which is very likely, we always only search in these. But as these are empty rows, we don't find anything. For finite sweep numbers this is an optimization at the FindIndizes call only. The check for non-finite endRow is needed as we don't upgrade labnotebooks from the analysis browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while working on #2184. No backport as that is an edgy-edge case.
Will merge once CI passes.