Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect discriminators of object enums in Scala 3 #1160

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Respect discriminators of object enums in Scala 3 #1160

merged 1 commit into from
Sep 17, 2024

Conversation

guersam
Copy link
Contributor

@guersam guersam commented Sep 17, 2024 •
edited
Loading

Fixes the regression from #1068:

Reproducer

@jsonDiscriminator("type")
enum ResponseFormat derives JsonCodec:
  case Text  
  case JsonObject

Expected encoding

{"type":"JsonObject"}

Actual encoding

"JsonObject"

@guersam guersam requested a review from a team as a code owner September 17, 2024 08:50
@fsvehla fsvehla merged commit e8b1b79 into zio:series/2.x Sep 17, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsvehla fsvehla fsvehla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guersam @fsvehla