Skip to content

Commit

Permalink
Update Scala, silencer, semanticdb (#1181)
Browse files Browse the repository at this point in the history
* CI: Scala 2.13.14

* Update silencer

* Update semanticDB

* set scala version to 2.13.15

* remove unnecessary @nowarn

* no fatal warnings
  • Loading branch information
fsvehla authored Oct 21, 2024
1 parent 7fc0ae8 commit c304ae5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 6 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
fail-fast: false
matrix:
java: ['17', '21']
scala: ['2.13.13']
scala: ['2.13.15']
steps:
- name: Checkout current branch
uses: actions/checkout@v4.1.2
Expand Down Expand Up @@ -79,7 +79,7 @@ jobs:
fail-fast: false
matrix:
java: ['17', '21']
scala: ['2.12.19', '2.13.13', '3.3.4']
scala: ['2.12.19', '2.13.15', '3.3.4']
platform: ['JVM', 'JS', 'Native']
steps:
- name: Checkout current branch
Expand Down
7 changes: 4 additions & 3 deletions project/BuildHelper.scala
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ object BuildHelper {
val Scala213: String = versions("2.13")
val ScalaDotty: String = "3.3.4"

val SilencerVersion = "1.7.16"
val SilencerVersion = "1.7.19"

private val stdOptions = Seq(
"-deprecation",
Expand All @@ -32,7 +32,8 @@ object BuildHelper {
"-unchecked"
) ++ {
if (sys.env.contains("CI")) {
Seq("-Xfatal-warnings")
// Seq("-Xfatal-warnings") // enable this when we are ready to enforce this
Nil
} else {
Nil // to enable Scalafix locally
}
Expand Down Expand Up @@ -229,7 +230,7 @@ object BuildHelper {
},
semanticdbEnabled := scalaVersion.value != ScalaDotty, // enable SemanticDB
semanticdbOptions += "-P:semanticdb:synthetics:on",
semanticdbVersion := "4.9.2",
semanticdbVersion := "4.10.2",
Test / parallelExecution := true,
incOptions ~= (_.withLogRecompileOnMacro(false)),
autoAPIMappings := true,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ package object golden {
else DiffResult.Different(x, y)
}

@nowarn implicit private lazy val diff: Diff[GoldenSample] = (x: GoldenSample, y: GoldenSample) =>
implicit private lazy val diff: Diff[GoldenSample] = (x: GoldenSample, y: GoldenSample) =>
Diff[Json].diff(x.samples, y.samples)

def goldenTest[A: Tag: JsonEncoder](
Expand Down

0 comments on commit c304ae5

Please sign in to comment.