Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deploy instant rewards to athens #189

Merged
merged 1 commit into from
Sep 19, 2024
Merged

feat: deploy instant rewards to athens #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publish-npm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ jobs:
env:
NODE_AUTH_TOKEN: ${{ secrets.NPM_TOKEN }}
GITHUB_REF: ${{ github.ref }}
continue-on-error: true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider the implications of allowing the job to continue despite errors.

Adding continue-on-error: true to the job configuration can lead to unexpected behavior or inconsistent state in subsequent steps if not handled carefully.

I recommend the following:

  1. Assess the criticality of the "Publish to NPM zeta app contracts" job for the overall workflow's success. If it's essential, consider removing the continue-on-error property to fail fast and prevent further issues.

  2. If allowing the job to fail silently is acceptable, ensure that proper error handling and logging mechanisms are in place to track and manage failures gracefully. This will help in identifying and debugging issues if they occur.

  3. Document the rationale behind allowing the job to continue despite errors, so that future maintainers understand the decision and its implications.

By addressing these points, you can strike a balance between resilience and reliability in your workflow design.


- name: Determine NPM Tag zevm app contracts
id: determine-npm-tag-zevm-app-contracts
Expand Down
3 changes: 2 additions & 1 deletion packages/zevm-app-contracts/data/addresses.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
"zetaSwapBtcInbound": "0x358E2cfC0E16444Ba7D3164Bbeeb6bEA7472c559",
"invitationManager": "0x3649C03C472B698213926543456E9c21081e529d",
"withdrawERC20": "0xa349B9367cc54b47CAb8D09A95836AE8b4D1d84E",
"ZetaXP": "0x5c25b6f4D2b7a550a80561d3Bf274C953aC8be7d"
"ZetaXP": "0x5c25b6f4D2b7a550a80561d3Bf274C953aC8be7d",
"InstantRewards": "0x10DfEd4ba9b8F6a1c998E829FfC0325D533c80E3"
},
"zeta_mainnet": {
"disperse": "0x23ce409Ea60c3d75827d04D9db3d52F3af62e44d",
Expand Down
2 changes: 1 addition & 1 deletion packages/zevm-app-contracts/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@zetachain/zevm-app-contracts",
"version": "0.0.6",
"version": "0.0.7",
"license": "MIT",
"author": "zetachain",
"publishConfig": {
Expand Down
Loading