Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement feature to disable invitation #148

Merged
merged 6 commits into from
Feb 2, 2024
Merged

feat: implement feature to disable invitation #148

merged 6 commits into from
Feb 2, 2024

Conversation

andresaiello
Copy link
Collaborator

@andresaiello andresaiello commented Jan 29, 2024 •
edited
Loading

Summary

  • Audit recommendation
    -- Disable invitations
    -- Add expiration to invites
    -- Use safe transfer

@andresaiello andresaiello marked this pull request as ready for review January 29, 2024 15:01
@socket-security Socket Security
Copy link

socket-security bot commented Feb 1, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@nomicfoundation/hardhat-verify@2.0.3 environment Transitive: eval, filesystem, network, shell, unsafe +289 141 MB fvictorio
npm/astral-regex@2.0.0 None 0 3.4 kB kevva
npm/cbor@8.1.0 None +1 206 kB hildjj
npm/lodash.clonedeep@4.5.0 None 0 48.2 kB jdalton
npm/lodash.truncate@4.4.2 None 0 19.8 kB jdalton
npm/nofilter@3.1.0 None 0 52 kB hildjj
npm/slice-ansi@4.0.0 None +4 59 kB sindresorhus
npm/table@6.8.1 None +10 477 kB gajus-table

🚮 Removed packages: npm/@nomiclabs/hardhat-etherscan@3.0.3, npm/cbor@5.2.0, npm/nofilter@1.0.4, npm/undici@4.16.0

View full report↗︎

lucas-janon
lucas-janon approved these changes Feb 2, 2024
View reviewed changes
Copy link
Contributor

@lucas-janon lucas-janon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andresaiello andresaiello merged commit f79723b into main Feb 2, 2024
10 checks passed
@andresaiello andresaiello deleted the andy/pd-5519-implement-feature-to-disable-invitation-on-manager branch February 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-janon lucas-janon lucas-janon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andresaiello @lucas-janon