-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tz info to all naive datetime object #120
Open
ranjanrak
wants to merge
6
commits into
zerodha:master
Choose a base branch
from
ranjanrak:fix-tz-info
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vividvilla
requested changes
Jul 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this will be breaking change so we need to release it as 3.10.0
or 4.0.0
, we can decide on this later.
vividvilla
requested changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1> Add IST timezone info to all naive DateTime objects.
Eg:
'order_timestamp': datetime.datetime(2021, 7, 1, 16, 45, 36, tzinfo=tzoffset('Asia/Kolkata', 19800)), 'exchange_timestamp': datetime.datetime(2021, 7, 1, 16, 45, 36, tzinfo=tzoffset('Asia/Kolkata', 19800)
2> Introduce proper logic(
is_timestamp
) to check if the response string is a timestamp field. Give away with an earlier string length comparison.3> Add optional
mode
field for order_margins.4> Add example with mode param for order_margins.
5> Change the way to handle exceptions for error responses, which don't have the
error_type
field(MF APIs).Ex: Kite error response is:
{'status': 'error', 'message': "Couldn't find that
order_id.", 'data': None, 'error_type': 'GeneralException'}
Where MF error response is:
{'status': 'error', 'message': 'Order not found', 'data': {}}
. Don't have error_type field in response.