Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sadhika tadinada PR 3 #2826

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sadhikatadinada
Copy link
Contributor

Thank you for making a pull request to ZTM's Animation Nation project. We will review your pull request as soon as we can, but keep in mind we can get very busy during Hacktoberfest.

While you're waiting, please look over this checklist. Feel free to write a description of what you did as well!

What I did

Optional: Edit this to tell us what you did!

Pull request checklist

  • This pull request uses HTML and CSS only and provides a meta.json file.
  • All files in this pull request are in a directory named: <github_username>-<art_name> without the <>.
  • Your pull request contains index.html and styles.css.
    • Your html file is named exactly: index.html
    • Your css file is named exactly: styles.css
  • Your pull request your meta.json with:
    • githubHandle: being your unique github user name,
    • artName : name of your animation
  • Your submission includes at least one animation.
  • Your pull request does not modify any other files in the repository.

Not normally needed

  • Check this if you would like to discuss an improvement besides adding animations

Note: if your pull request makes an improvement besides adding a CSS animation you will need to discuss this with the maintainers. You can help kickstart this process by explaining what your change does and why you are making it in the "What I did" section

What to expect

  • If your pull request meets the checklist requirements it will be approved and merged by a maintainer
  • If your pull request needs some changes. A maintainer will leave a comment requesting changes
  • If your pull request significantly violates the criteria in the checklist it will be closed with feedback.

Copy link

🙏 Thanks for your pull request @sadhikatadinada, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2826 177 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 357 3566

Copy link
Contributor

@LaurelineP LaurelineP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aloha @sadhikatadinada and thanks for your contribution.
Not accepting any JS for contribution,

  • Please either close your PR or address the feedback

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS Not accepted in contribution

As the README.md states - we do not accept contribution using JS
The contribution should only be about an animation / creative animation without any logic or use of third part library to handle css

Observing what you have here:
What you could do is using CSS to animate all cells to show a tic tac toe round.
Using css timers to delay cells if needed.

Either close this PR / either adjust this PR so it does not use ANY JS

@LaurelineP LaurelineP added the invalid This doesn't seem right label Oct 25, 2024
Copy link

🙏 Thanks for your pull request @sadhikatadinada, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2826 177 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 357 3566

1 similar comment
Copy link

🙏 Thanks for your pull request @sadhikatadinada, The team will now review and merge this request. In the mean time why not check out some of the other opensource projects available, contributions are greatly appreciated!

Some of the most popular are


PR Statistics

#️⃣ PR Number: Line Additions: 🗑️ Line Deletions:
2826 177 0
📑 Files Changed: Repo Stars: 🔱 Total Forks:
3 357 3566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants