Introduce a "cross" slot for ui.interactive_image
#3870
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falkoschindler
force-pushed
the
cross-slot
branch
from
c0b5544
to
4846aaf
Compare
|
The implementation has been cherry-picked into PR #3848. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to PR #3848, this pull request adds a "cross" slot for defining custom SVG crosshairs. This avoids adding more and more parameters for customizing the existing cross.
I'll mark this PR as draft. Once accepted, I'd like to apply these changes to PR #3848 so that @parlance-zz gets recognized as a contributor.