Speedup tornado workflow by moving axis during driving. #191
+74
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR contains changes to generally speed up the tornado workflow aswell as allow the y-axis and tornado angle to be adjusted whilst approaching the next crop.
For some background:
The current speed of a tornado workflow is around 30-35 seconds. 5 seconds are from adjusting the tornado angle and another 1-2 seconds come from the y-axis moving.
This change would optimally save 7 seconds per workflow. For 10 000 plants this mounts up to 20 hours of time saved (optimally).
There are still some considerations to be had about handling errors and correctly canceling the axis movement, but it is in a working state.