Fix rendering errors on enabling/resizing monitors #1344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The guard added in commit 0aa620 to avoid duplicates filters out all Configure events on the root window, causing picom to not properly render the screen area after display configuration changes, such as adding or resizing a monitor. Only apply the guard if the Configure event affects a window other than the root window. Fixes #1338
|
Thank you, fixed! Checks pass now |
|
Nice catch! Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #1338 - commit 0aa6202 introduced a problem with display changes, where root window Configure events would be ignored due to the new conditional, since the event comes from the root window itself. This is a small PR just moving that conditional, to make sure that root window events are always processed, and the filter only applies on other windows.