wm/win: fix handling of windows with multiple window types #1307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ICCCM states a window can have multiple types, which we didn't handle. Fixing this also includes a slight change to the dbus interface, I hope that doesn't break too many people. Also this is pretty unfixable for `wintypes`, and we are moving to universal rules anyway, so I didn't bother. Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1307 +/- ##
==========================================
- Coverage 54.33% 54.31% -0.03%
==========================================
Files 70 70
Lines 14868 14891 +23
==========================================
+ Hits 8079 8088 +9
- Misses 6789 6803 +14
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ICCCM states a window can have multiple types, which we didn't handle.
Fixing this also includes a slight change to the dbus interface, I hope that doesn't break too many people.
Also this is pretty unfixable for
wintypes, and we are moving to universal rules anyway, so I didn't bother.