Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add extension recommendations #81

Merged
merged 3 commits into from
May 5, 2024
Merged

feat: add extension recommendations #81

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c91f655
feat: add extensions recommendations
Hanna922 May 5, 2024
0703cdb
fix: apply vscode-styled-components extensions
Hanna922 May 5, 2024
fde6e1b
fix: `setToastAnimation` 호출 수정
nijuy May 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"recommendations": [
"esbenp.prettier-vscode",
"dbaeumer.vscode-eslint",
"jpoissonnier.vscode-styled-components"
]
}
10 changes: 6 additions & 4 deletions src/components/Toast/Toast.style.ts
View file
Open in desktop
Copy link
Collaborator

@nijuy nijuy May 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setToastAnimation 호출하는 쪽에서는 animation: 이 붙어있어서 현재 토스트가 화면에 나타나지 않스빈다
수정해서 커밋 하나만 날려놨어요!

Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@ const setToastAnimation = ($duration: ToastDuration) => {
switch ($duration) {
case 'short':
return css`
${ToastFadeIn} ${FADE_DURATION}s ease-in forwards,
${ToastFadeOut} ${FADE_DURATION}s ${SHORT_DURATION + FADE_DURATION}s ease-out forwards
animation:
${ToastFadeIn} ${FADE_DURATION}s ease-in forwards,
${ToastFadeOut} ${FADE_DURATION}s ${SHORT_DURATION + FADE_DURATION}s ease-out forwards;
`;
case 'long':
return css`
${ToastFadeIn} ${FADE_DURATION}s ease-in forwards,
${ToastFadeOut} ${FADE_DURATION}s ${LONG_DURATION + FADE_DURATION}s ease-out forwards
animation:
${ToastFadeIn} ${FADE_DURATION}s ease-in forwards,
${ToastFadeOut} ${FADE_DURATION}s ${LONG_DURATION + FADE_DURATION}s ease-out forwards;
`;
}
};
Expand Down
Loading