fix: shoving searchPrefix in SearchTextField #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hanna922
changed the title
nijuy
approved these changes
May 16, 2024
| display: none; | ||
| `; | ||
|
|
||
| export const StyledSearchPrefixContainer = styled.div` | ||
| display: flex; |
There was a problem hiding this comment.
왜 size: 1.5rem 해놨는데 보장이 안됐는지
StyledTextFieldWrapper에서 display: flex 로 요소 가로 정렬 중인데,
내부 아이템의 flex-shrink 기본값이 1이라 너비 무시하고 걍 줄어들 때가 있어요
아마 얘도 같은 문제지 싶은데. . . 자세한 내용은 yourssu/Soomsil-Web#153 보시면 좋을 거 같습니당
근데 1.25rem이네. 제가 왜 저렇게 넣어놨는지는? 몰으겠습니다 감사하다
지금은 이렇게 해결해도 괜찮은데 나중에 같은 문제를 다른 곳에서 만나면 flex 내부 아이템에 flex-shrink 속성을 부여해서 해결하는 게 깔끔할 거 같습니다!! 매번 컴포넌트로 감쌀 수 없으니까!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1️⃣ 어떤 작업을 했나요? (Summary)
기존 코드에 영향을 미치는 변경사항
피그마 상에서 SearchPrefix icon 크기는 20 * 20이고, div로 감싸면 간단하게 해결 되어서 이렇게 작업했습니다.
추가로 StyledSuffixIconContainer에 타입이 불필요해서 삭제했습니다.
3️⃣ 추후 작업
진짜진짜진짜 배포.
4️⃣ 체크리스트 (Checklist)
main브랜치의 최신 코드를pull받았나요?