Add simple delete for MANY_MANY #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We should always delete records even if all related are new * Now $deleteAttributes fills up only once from ownerMap and then we build condition by owner attributes, ignoring related
hippostar
pushed a commit
to hippostar/with-related-behavior
that referenced
this pull request
Feb 21, 2014
…es to models that are no longer referenced by owner model. Does not delete the actual models, only join table links. - Implement unlink for MANY_TO_MANY relations. - Re-uploading the same changes as the last commit but fixing the whitespace bug making it impossible to see actual changes. - Changed the "delete" part of the code to only do *ONE* query. Copied from official pull request yiiext#32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to add just now simple delete logic to MANY_MANY relation. Not waiting for implementing of link/unlink.
Logic there is straight enough: remove in connection table all records, that related to owner. For example in case of saving article with tags we should just delete from article_tag all records, where article_id = 123. It will be enough for all cases, as later insert command adds all really needed records.
In the meantime we have tests written in AntonTyutin/yii-with-related-behavior@e00fc07 fork.
ps: I have read all related issues and comments