Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Pydantic v2 migration #470

Closed
wants to merge 7 commits into from
Closed

✨ Pydantic v2 migration #470

wants to merge 7 commits into from

Conversation

yezz123
Copy link
Owner

@yezz123 yezz123 commented Jun 24, 2023

No description provided.

@yezz123 yezz123 added documentation Improvements or additions to documentation enhancement New feature or request dependencies Pull requests that update a dependency file labels Jun 24, 2023
@yezz123 yezz123 self-assigned this Jun 24, 2023
@vercel
Copy link

vercel bot commented Jun 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
authx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 10:54pm
authx-old ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 10:54pm

@codecov
Copy link

codecov bot commented Jun 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (90dd778) 90.24% compared to head (1c8a1e4) 90.30%.
Report is 2 commits behind head on main.

❗ Current head 1c8a1e4 differs from pull request most recent head fe8d036. Consider uploading reports for the commit fe8d036 to get more accurate results

Files Patch % Lines
authx/schema.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #470      +/-   ##
==========================================
+ Coverage   90.24%   90.30%   +0.05%     
==========================================
  Files          26       25       -1     
  Lines        1282     1165     -117     
  Branches      205      183      -22     
==========================================
- Hits         1157     1052     -105     
+ Misses         83       81       -2     
+ Partials       42       32      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patrick91
Copy link

@yezz123 is there anything I can do to help you land this PR?

@yezz123
Copy link
Owner Author

yezz123 commented Oct 1, 2023

Hey, @patrick91, thanks for reaching out and your willingness to help 🙏🏻

I really appreciate it. I've been taking some time off recently, but I'm now back and ready to start reviewing the changes in this PR and push some updates.

My main idea of supporting both versions of Pydantic sounds excellent and will definitely help maintain broader compatibility.

Please let me know if you have any specific suggestions or areas you'd like to contribute to.

Thanks again for your support 🙌🏻

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

sonarcloud bot commented Nov 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@artemonsh
Copy link

any updates?

@yezz123
Copy link
Owner Author

yezz123 commented Jan 16, 2024

Any updates?

I'm thinking of keeping this one until I finish the documentation and then I will get back to it, it's on my milestone 🙏🏻

@yezz123 yezz123 closed this Feb 8, 2024
@yezz123 yezz123 deleted the pydantic2 branch February 8, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

4 participants