Don't persist timeout-based opt-out #41
Conversation
| @@ -4,7 +4,15 @@ var Insight = require('../../lib'); | |||
| var insight = new Insight({ | |||
| packageName: 'yeoman', | |||
| packageVersion: '0.0.0', | |||
| trackingCode: 'GA-1234567-1' | |||
| trackingCode: 'GA-1234567-1', | |||
| config: { | |||
There was a problem hiding this comment.
We should just rely on sinon to mock this object and make assertion against the call. Reading from the stderr/out for assertion purposes is kind of dirty.
There was a problem hiding this comment.
I'd rather not bind up this externally-observable change on a minor overhaul of testing patterns. Would you be willing to land the PR as-is and revisit process mocking at your own convenience?
There was a problem hiding this comment.
Not really, thing skipped in review would probably never end up being done. This should be fairly easy for you to test here.
There was a problem hiding this comment.
I've fixed merge conflicts (thanks, @sindresorhus), but don't see how to fulfill this request, given that we're dealing with child processes. If you're going to block on it, then I suppose the PR should be closed (unless someone else has an idea).
|
ping :) |
Fixes gh-39