Adapt kernel #1299
Merged
Adapt kernel #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teclator
reviewed
Jan 24, 2024
| # live installation does not create /etc/install.inf (bsc#793065) | ||
| tmp = if Mode.live_installation | ||
| # Check if /etc/install.inf exists | ||
| tmp = if SCR.Dir(path(".etc.install_inf")).empty? |
There was a problem hiding this comment.
I guess /etc/install.inf should be already copied in the target system when this check is done as well as the read is performed but we have to be careful about it.
There was a problem hiding this comment.
well, I keep it working as before...so previously it calls SCR.Execute..so I use also SCR for Dir to check existence.
|
✔️ Internal Jenkins job #226 successfully finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In agama there are no /etc/install.inf, but kernel parsing depends on it. Result is that kernel parameters are not properly passed to installed system.
Solution
Read /proc/cmdline when /etc/install.inf is not available.
Testing