add product update summary to proposal (jsc#PED-3773) #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package/yast2-update.changes
Outdated
| ------------------------------------------------------------------- | ||
| Wed Jan 17 11:56:33 UTC 2024 - Josef Reidinger <jreidinger@suse.com> | ||
|
|
||
| - Show the partition selected for upgrade in the installation |
There was a problem hiding this comment.
I would say "Show the block device", because it can also be a LVM LV.
| product_info = "<li>" + format( | ||
| _("Updating %{product} on root %{partition}"), | ||
| product: RootPart.GetInfoOfSelected(:name), | ||
| partition: RootPart.selectedRootPartition |
There was a problem hiding this comment.
Could you please check an installation with LVM? Just to be sure that #selectedRootPartition contains theh value in that case.
There was a problem hiding this comment.
yeap, here is partition selection and also summary. So we are consistent:
|
✔️ Internal Jenkins job #4 successfully finished |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In systems with multiple partitions and systems it is not visible in summary what system/partition will be updated.
trello: https://trello.com/c/8K5XiQej/3522-upgrade-show-the-partition-selected-for-upgrade-in-the-installation-proposal
jira: https://jira.suse.com/browse/PED-3773
Solution
Add to Update section line with system and partition that is going to be upgraded.
Testing
Screenshots