-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add product update summary to proposal (jsc#PED-3773) #195
Conversation
package/yast2-update.changes
Outdated
------------------------------------------------------------------- | ||
Wed Jan 17 11:56:33 UTC 2024 - Josef Reidinger <jreidinger@suse.com> | ||
|
||
- Show the partition selected for upgrade in the installation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say "Show the block device", because it can also be a LVM LV.
product_info = "<li>" + format( | ||
_("Updating %{product} on root %{partition}"), | ||
product: RootPart.GetInfoOfSelected(:name), | ||
partition: RootPart.selectedRootPartition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please check an installation with LVM? Just to be sure that #selectedRootPartition
contains theh value in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✔️ Internal Jenkins job #4 successfully finished |
Problem
In systems with multiple partitions and systems it is not visible in summary what system/partition will be updated.
trello: https://trello.com/c/8K5XiQej/3522-upgrade-show-the-partition-selected-for-upgrade-in-the-installation-proposal
jira: https://jira.suse.com/browse/PED-3773
Solution
Add to Update section line with system and partition that is going to be upgraded.
Testing
Screenshots