Adapt to SCC API Change: 'base' -> 'isbase' [SLE-15-SP1] #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shundhammer
force-pushed
the
huha-isbase-15-sp1
branch
from
baa7510
to
c6df397
Compare
|
Submitted to IBS as https://build.suse.de/request/show/313363 |
This was referenced Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Target Branch
This is for SLE-15-SP1.
See section Related PRs below for other target branches.
Bugzilla
https://bugzilla.suse.com/show_bug.cgi?id=1217317
Problem
Migration to a newer SLE-15 SP fails with an unrecoverable exception
Caught error: NoMethodError: "undefined method `friendly_name' for nil:NilClass"
Notice that this happens with the old release while preparing the migration, even before the installation media with the newer release is booted.
Cause
The API of SCC changed. The previous boolean field / method
basewas renamed toisbase.This should never have happened in the first place during the lifetime of SLE-15. But now that the damage is done, we have to adapt to the change to minimize customer impact.
Fix
Cherry-picked @imobachgs's fix 431d937 which does a global
s/base/isbase/in this source repo for the code and the test case.Affected Scenarios
@lslezak wrote on IRC:
Target Branches and Related PRs
Original PR where this patch was cherry-picked from: Use isbase #561
For SLE-15-SP2: Adapt to SCC API Change: 'base' -> 'isbase' [SLE-15-SP2] #592
For SLE-15-SP3: Adapt to SCC API Change: 'base' -> 'isbase' [SLE-15-SP3] #593
SLE-15-SP4, -SP5, -SP6 are not affected; the original patch was for SP4 and merged forward.
SLE-15-GA went out of support.