fix: only enable interactivity if stdin is a TTY too #6437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merceyz
reviewed
Aug 11, 2024
| @@ -1790,7 +1790,10 @@ export class Configuration { | |||
| return {os, cpu, libc}; | |||
| } | |||
|
|
|||
| isInteractive({interactive, stdout}: {interactive?: boolean, stdout: Writable}): boolean { | |||
| isInteractive({interactive, stdin, stdout}: {interactive?: boolean, stdin: Readable, stdout: Writable}): boolean { | |||
There was a problem hiding this comment.
🤔 Indeed, didn't realize 4.4.0 was released with the previous PR.
Given the fact that GH code search doesn't return anything for configuration.isInteractive and the change has only been out for one week, I'd say there's about a 0% chance that anybody is using it and would prefer to land this change before anybody gets the chance to use it, even though it's theoretically a breaking change.
There was a problem hiding this comment.
It's probably fine but could we make it optional with a TODO note to fix it for the next major?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Addresses #6419 (comment).
#6419 made Yarn non-interactive when the
stdoutisn't a TTY, but it makes sense to disable interactivity when thestdinisn't interactive too.How did you fix it?
Made it check whether both
stdoutandstdinare TTYs before enabling interactivity.This way both of the following commands will always be non-interactive:
yarn add lodash > foo.txtecho '' | yarn add lodashChecklist