Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export Y18N class #136

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

dopry
Copy link

@dopry dopry commented Jun 2, 2021

allows users to explicitly construct their Y18N instance with their
own choice of shim.

Copy link

@atlslscsrv-app atlslscsrv-app left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved
signed of by Laura Vanlaningham
dopry:chore/exportY18N.diff
(stayloveable@outlook.com)

@dopry
Copy link
Author

dopry commented Aug 9, 2021

@bcoe who should I contact about reviewing and merging this PR?

@bcoe
Copy link
Member

bcoe commented Aug 13, 2021

@dopry thanks for the patch, I will do my best to land soon.

@dopry
Copy link
Author

dopry commented Nov 8, 2021

@bcoe hey do you need me to rebase this or anything? I'm still running on a fork and would really like to get back on upstream.

@bcoe
Copy link
Member

bcoe commented Nov 9, 2021

@dopry my bad, I lost track of this. It looks like this potentialy breaks the ESM exports unfortunately, any ideas?

allows users to explicitly construct their Y18N instance with their
own choice of shim.
@dopry
Copy link
Author

dopry commented Nov 9, 2021

It looks like I needed to leave out the opts interface in the CJS file. JS doesn't understand interfaces. It should pass now.

test/esm/y18n-test.mjs Outdated Show resolved Hide resolved
@dopry
Copy link
Author

dopry commented Nov 12, 2022

not off hand. I'm busy on other projects for the foreseeable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants