define CAML_COMPATIBILITY_H to allow more idents
#712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`compatibility.h` defines preprocessor macros which means certain identifiers, such as `alloc` cannot be used. This is a problem when binding with cstubs when structs have fields with the same identifiers.
|
I think the proper fix is to make sure that we're using "namespaced" identifiers in the C code (that is, starting with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compatibility.hdefines preprocessor macros which means certain identifiers, such asalloccannot be used. The preprocessor expands the identifier intocaml_xxxin theoffset_of.This is a problem when binding with cstubs when structs have fields with the same identifiers. Currently, you can manually add this
#definein the preamble manually as a workaround.Note:
compatibility.his removed in ocaml5, but is present until4.14.