Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FindPython's numpy component to find numpy include directories #296

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

dokempf
Copy link
Contributor

@dokempf dokempf commented Nov 28, 2023

The current way how numpy is searched for depends on the deprecated FindPythonInterp that is slowly being phased out (see https://cmake.org/cmake/help/latest/module/FindPythonInterp.html). Luckily, the replacement FindPython offers an out-of-the-box solution to find the NumPy headers which allows great simplification of the xtensor-python CMake code. The only downside is that it requires bumping the required CMake version to 3.14.

@JohanMabille
Copy link
Member

Thanks a lot! And sorry for the time it took to get in.

@JohanMabille JohanMabille merged commit 1b14707 into xtensor-stack:master Jan 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants